[DX] Dockerfile and docker-compose#2787
Closed
alanpoulain wants to merge 1 commit into
Closed
Conversation
Contributor
|
I just use the Docker setup from api-platform/api-platform, and do (in the
|
Contributor
We should keep Having them in this repo will create more confusion. |
Member
Author
I was thinking this too, that's why it's a proposal. I don't know, maybe if it's correctly explained it will not cause confusion. |
Member
|
I'm -1 too. Our skeleton and symfony/flex#128 should be enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using Docker for testing API Platform and I think it could be interesting to add it to API Platform to improve DX.
The image comes with MongoDB and XDebug.
It's complementary to #2703 because even if the tests are not run with MongoDB by default, if some tests related to MongoDB fail in Travis, you might need to run them locally.
WDYT?